Ractor: Fix moving embedded objects #12997
Closed
+161
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4cb7f6f to
7fcc768
Compare
7fcc768 to
844b344
Compare
casperisfine
commented
Mar 27, 2025
| @@ -3585,8 +3585,27 @@ move_enter(VALUE obj, struct obj_traverse_replace_data *data) | |||
| return traverse_skip; | |||
| } | |||
| else { | |||
| VALUE moved = rb_obj_alloc(RBASIC_CLASS(obj)); | |||
There was a problem hiding this comment.
Also this was preserving the metaclass so perhaps using dup is incorrect.
There was a problem hiding this comment.
That said, the previous behavior wasn't particularly useful:
>> o = Object.new
=> #<Object:0x000000012b396a30>
>> def o.foo = 12
=> :foo
>> Ractor.new { Ractor.receive }.send(o, move: true).take
(irb):3: warning: Ractor is experimental, and the behavior may change in future versions of Ruby! Also there are many implementation issues.
<internal:ractor>:600:in 'Ractor#send': can't create instance of singleton class (TypeError)|
@jhawthorn pointed that |
`rb_obj_alloc(RBASIC_CLASS(obj))` will always allocate from the basic 40B pool, so if `obj` is larger than `40B`, we'll create a corrupted object when we later copy the shape_id. I chose to use specialized `rb_*_dup` functions when possible to benefit from shared String/Arrays and trigger write barriers. For some other types I resorted to the generic `rb_obj_dup`. It works but probably isn't ideal.
844b344 to
f5b9be8
Compare
✅ All Tests passed!✖️no tests failed ✔️61729 tests passed(8 flakes) |
|
Closing in favor of: #13008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rb_obj_alloc(RBASIC_CLASS(obj))will always allocate from the basic 40B pool, so ifobjis larger than40B, we'll create a corrupted object when we later copy the shape_id.I chose to use specialized
rb_*_dupfunctions when possible to benefit from shared String/Arrays and trigger write barriers.For some other types I resorted to the generic
rb_obj_dup. It works but probably isn't ideal.