Skip to content

Improve backtrace of errors raised by Socket.tcp_with_fast_fallback #13041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

Improve backtrace of errors raised by Socket.tcp_with_fast_fallback #13041

merged 1 commit into from
Apr 2, 2025

Conversation

casperisfine
Copy link
Contributor

[Bug #21211]

Socket errors raised from background threads are hard to track down because their backtrace starts from the spawned thread.

To solve this we can raise a new error with the old one as cause.

@byroot
Improve backtrace of errors raised by Socket.tcp_with_fast_fallback
a28de9e 
[Bug #21211]

Socket errors raised from background threads are hard to track down because
their backtrace starts from the spawned thread.

To solve this we can raise a new error with the old one as `cause`.
@byroot byroot requested a review from shioimm April 2, 2025 10:28
shioimm
shioimm approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@shioimm shioimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for solving this!

@byroot byroot merged commit 580aa60 into ruby:master Apr 2, 2025
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shioimm shioimm shioimm approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@casperisfine @shioimm @byroot