Add a test for failing assertions in vm_args.c #13043
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git bisect points at ruby#12596
✅ All Tests passed!✖️no tests failed ✔️61679 tests passed(7 flakes) |
|
Thanks for the report. I'll look into this today, and if I can't fix it quickly, I'll revert the change. |
|
No rush! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git bisect points at #12596
@jeremyevans @peterzhu2118 I have very limited understanding of that code, so I can't tell if the assertions are incorrect or if something bad is happening.
I however added a test case that make the assertions fail.