Fix moving composite object parts #13045
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some bugs were introduced in commit 0350290 that had to do with moving composite object parts. This fixes those bugs and adds tests for those cases.
9f7467f to
7abb0f9
Compare
|
Sorry only seeing this now. Not sure if you saw but I did some followup a couple weeks ago: #13070 As far as I can tell your test isn't failing on master, but I think it would make sense to merge it. |
|
I merged the test at 72dc16a |
✅ All Tests passed!✖️no tests failed ✔️28480 tests passed(4 flakes) |
|
Yeah I saw your recent commit and figured the test could still be useful. Thanks @byroot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bugs were introduced in commit 0350290 that had to do with moving composite object parts. This fixes those bugs and adds tests for those cases.