Ensure builtin binaries are aligned to ibf_header #13073
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `builtin_binary` buffers are cast to `ibf_header` later, but may not be aligned to the necessary boundaries (in this case, 4 bytes). Signed-off-by: Jens Reidel <adrian@travitia.xyz>
nobu
requested changes
Apr 6, 2025
| static const unsigned char <%= feature %>_bin[] = { | ||
| #include "compile.h" | ||
|
|
||
| static const unsigned char <%= feature %>_bin[] __attribute__((aligned(alignof(struct ibf_header)))) = { |
There was a problem hiding this comment.
It works with GCC and Clang. It doesn't with MSVC, I guess I can come up with a way that will also work with MSVC. Is there any other compiler I need to be aware of?
|
IBF dump string size should be multiple of 4 always. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
builtin_binarybuffers are cast toibf_headerlater, but may not be aligned to the necessary boundaries. In particular, Ruby was crashing for me on ARMv7 + musl with LLVM 19.1.7 because it was not aligned to the 4-byte boundary, resulting inSIGBUSwhen dereferencing the header.https://godbolt.org/z/ss8WeE88c