Fix LLDB scripts by using the toplevel RBasic #13096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eightbitraptor
approved these changes
Apr 10, 2025
| @@ -68,7 +68,7 @@ def vm_frame_magic(self, cfp): | |||
| return self.VM_FRAME_MAGIC_NAME.get(frame_type, "(none)") | |||
|
|
|||
| def rb_iseq_path_str(self, iseq): | |||
| tRBasic = self.target.FindFirstType("struct RBasic").GetPointerType() | |||
| tRBasic = self.target.FindFirstType("::RBasic").GetPointerType() | |||
There was a problem hiding this comment.
I had no idea you could reference constants like this! This is great.
This comment has been minimized.
This comment has been minimized.
Move _append_command_output and _append_expression to LLDBInterface, and use it from HeapPageCommand after setting result.
`rp` and other commands were broken for me because they always showed
the object as a T_NONE.
The reason was that instead of returning the type `struct RBasic`,
FindFirstType("struct RBasic") was returning
`yjit::cruby::autogened::RBasic`.
Explicitly asking for the top-level RBasic by prefixing it with `::` is
enough to fix those commands.
67d9bf7 to
e1f544c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @eightbitraptor we figured the issue I had in #13048 by using
target.FindTypesinstead and looking at the results.target.FindFirstType("struct RBasic")was returning theyjit::cruby::autogened::RBasictype instead ofstruct RBasicand then somehow getting the flags always returned 0.Explicitly asking for the toplevel namespace
RBasicby prefixing with::fixes that issue.I also took the opportunity to fix the
heap_pagecommand by moving some parts ofRbInspectorintoLLDBInterfaceand setting theresultin thecallmethod.rbbtis still broken for me anddump_pagejust never returns or is very slow, but I still fixed the usage there for good measure.Before
After