[Feature #20724] Bump Unicode version to 16.0.0 #13117
Merged
+9,177
−6,917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Removing gsub may make this much slower. There should be no need for such big changes. |
nobu
reviewed
Apr 17, 2025
template/unicode_norm_gen.tmpl
Outdated
|
|
||
| quick_checks = %w(NFD_QC NFC_QC NFKD_QC NFKC_QC) | ||
|
|
||
| File.foreach('enc/unicode/data/16.0.0/ucd/DerivedNormalizationProps.txt') do |line| |
There was a problem hiding this comment.
Use InputDataDir and vpath, not the hardcoded path.
Suggested change
| File.foreach('enc/unicode/data/16.0.0/ucd/DerivedNormalizationProps.txt') do |line| | |
| vpath.foreach("#{InputDataDir}/DerivedNormalizationProps.txt") do |line| |
nobu
reviewed
Apr 17, 2025
lib/unicode_normalize/normalize.rb
Outdated
| def self.to_nfkd_arr(string) | ||
| kompatibled_arr = string.each_char.flat_map { kompatible_one(it) } | ||
| decomposed_arr = kompatibled_arr.each.flat_map { decompose_one(it) } | ||
| ordered_arr = canonical_ordering(decomposed_arr) |
There was a problem hiding this comment.
ordered_arr is assigned but unused variable.
Suggested change
| ordered_arr = canonical_ordering(decomposed_arr) | |
| canonical_ordering(decomposed_arr) |
diff --git a/common.mk b/common.mk
index 8d1ea8815a1..d8d6e2525e3 100644
--- a/common.mk
+++ b/common.mk
@@ -1245,7 +1245,12 @@ srcs-extra: $(EXTRA_SRCS)
realclean-srcs-extra::
$(Q)$(RM) $(EXTRA_SRCS)
-LIB_SRCS = $(srcdir)/lib/unicode_normalize/tables.rb
+UNICODE_NORMALIZE_TABLES = $(srcdir)/lib/unicode_normalize/tables.rb
+encs: $(ALWAYS_UPDATE_UNICODE:yes=update-unicode_normalize-tables)
+
+update-unicode_normalize-tables: $(UNICODE_NORMALIZE_TABLES)
+
+LIB_SRCS = $(UNICODE_NORMALIZE_TABLES)
srcs-lib: $(LIB_SRCS)
|
|
[unicode_normalize/tables.rb should not only be updated when ALWAYS_UPDATE_UNICODE=yes. It should e.g. be updated when template/unicode_norm_gen.tmpl is changed. And makefile-related changes should be independent of updates for Unicode 16.0.0. |
3685ad0 to
97f35c7
Compare
0363..036F ; Alphabetic # Mn [13] COMBINING LATIN SMALL LETTER A..COMBINING LATIN SMALL LETTER X
97f35c7 to
f7b53e3
Compare
|
@duerst I removed make-file changes from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.unicode.org/versions/Unicode16.0.0/
https://bugs.ruby-lang.org/issues/20724