Fix VMDEBUG #13147
Open
Fix VMDEBUG #13147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,13 +65,6 @@ calc_pos(const rb_iseq_t *iseq, const VALUE *pc, int *lineno, int *node_id) | |||
| /* use pos-1 because PC points next instruction at the beginning of instruction */ | |||
| pos--; | |||
| } | |||
| #if VMDEBUG && defined(HAVE_BUILTIN___BUILTIN_TRAP) | |||
There was a problem hiding this comment.
We end up in this branch fairly frequently with pos == 0. I've removed it for now, otherwise this will terminate any program right away.
| @@ -381,6 +381,8 @@ vm_stack_dump_each(const rb_execution_context_t *ec, const rb_control_frame_t *c | |||
| else { | |||
| rb_bug("unsupported frame type: %08lx", VM_FRAME_TYPE(cfp)); | |||
| } | |||
| error: | |||
There was a problem hiding this comment.
The kprintf macro used above has a goto error. All of this is within a #if VMDEBUG > 2
| @@ -429,7 +429,7 @@ vm_push_frame(rb_execution_context_t *ec, | |||
|
|
|||
| ec->cfp = cfp; | |||
|
|
|||
| if (VMDEBUG == 2) { | |||
| if (VMDEBUG == 2 && rb_current_execution_context(false) != NULL) { | |||
There was a problem hiding this comment.
Without this I get:
../vm_core.h:1988: Assertion Failed: rb_current_execution_context:!expect_ec || ec != NULL
It happens during vm init, pushing a dummy frame before ruby_current_ec has been set (Init_BareVM -> th_init -> rb_ec_initialize_vm_stack -> vm_push_frame).
dccccbc to
7d40279
Compare
nobu
reviewed
Apr 23, 2025
7d40279 to
6348379
Compare
This comment has been minimized.
This comment has been minimized.
I've found some of the VMDEBUG levels helpful in learning how things work. But prior to this commit there were some compile errors, as well as a failed assertion and an early exit. I'd guess that VMDEBUG is not commonly used, and these things didn't get updated as the surrounding code changed.
6348379 to
a2f646c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found some of the VMDEBUG levels helpful in learning how things work. But prior to this commit there were some compile errors, as well as a failed assertion and an early exit. I'd guess that VMDEBUG is not commonly used, and these things didn't get updated as the surrounding code changed.