Add missing lock in rb_gc_impl_define_finalizer
#13151
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`objspace->finalizer_table` must be synchronized,
otherwise concurrent insertion from multiple ractors
will cause a crash.
Repro:
```ruby
ractors = 5.times.map do |i|
Ractor.new do
100_000.times.map do
o = Object.new
ObjectSpace.define_finalizer(o, ->(id) {})
o
end
end
end
ractors.each(&:take)
```
✅ All Tests passed!✖️no tests failed ✔️61959 tests passed(2 flakes) |
tekknolagi
reviewed
Apr 22, 2025
| @@ -2834,6 +2834,8 @@ rb_gc_impl_define_finalizer(void *objspace_ptr, VALUE obj, VALUE block) | |||
|
|
|||
| RBASIC(obj)->flags |= FL_FINALIZE; | |||
|
|
|||
| int lev = rb_gc_vm_lock(); | |||
|
|
|||
There was a problem hiding this comment.
I can't add a line comment since you didn't modify that block, but do you have to unlock at 2849 before the early return?
tekknolagi
reviewed
Apr 22, 2025
| @@ -973,6 +973,8 @@ rb_gc_impl_define_finalizer(void *objspace_ptr, VALUE obj, VALUE block) | |||
|
|
|||
| RBASIC(obj)->flags |= FL_FINALIZE; | |||
|
|
|||
| int lev = rb_gc_vm_lock(); | |||
There was a problem hiding this comment.
(as above with early return)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
objspace->finalizer_tablemust be synchronized,otherwise concurrent insertion from multiple ractors will cause a crash.
Repro:
FYI: @tenderlove @jhawthorn @etiennebarrie