Skip to content

Unicode version check #13154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2025
Merged

Unicode version check #13154

merged 2 commits into from
Apr 23, 2025

Conversation

nobu
Copy link
Member

@nobu nobu commented Apr 23, 2025 •
edited
Loading

Embed the version as Encoding::UNICODE_VERSION and check the version of the normalization table.

@nobu nobu requested review from duerst and ima1zumi April 23, 2025 04:13
@nobu nobu changed the title Encoding unicode version Unicode version check Apr 23, 2025
@launchable-app Launchable app
Copy link

launchable-app bot commented Apr 23, 2025 •
edited
Loading

✅ All Tests passed!

✖️no tests failed ✔️61959 tests passed(3 flakes)

@nobu nobu merged commit 59c7b38 into ruby:master Apr 23, 2025
86 checks passed
@nobu nobu deleted the encoding-unicode_version branch April 23, 2025 05:43
duerst
duerst reviewed Apr 23, 2025
View reviewed changes
lib/unicode_normalize/tables.rb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry to be late with my review, but I don't understand why the Unicode version is hardcoded here. That only produces additional work when upgrading to a new version next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duerst duerst duerst left review comments

@ima1zumi ima1zumi ima1zumi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nobu @duerst @ima1zumi