Deprecate ObjectSpace._id2ref
#13157
Open
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Feature #15408] Matz decided to deprecate it for Ruby 2.6 or 2.7 but that never actually happened. Given the object_id table is a contention point for Ractors it seems sensible to finally deprecate this API so we can generate and store object ids more efficiently in the future.
0ed7605 to
5ca30fa
Compare
✅ All Tests passed!✖️no tests failed ✔️61694 tests passed(2 flakes) |
casperisfine
pushed a commit
to Shopify/sorbet
that referenced
this pull request
Apr 23, 2025
This method was supposed to be deprecated for Ruby 2.7 but fell through the cracks, I'm working on making it happen: ruby/ruby#13157 In addition, Ruby 3.5.0 already has some optimizations in place that are de-optimized if `_id2ref` is ever called: ruby/ruby#13115 And one more issue is that `_id2ref` doesn't work well with ractors. Instead we can hold our own weakmap. It's probably not the ideal implementation, but I chose to not go for too large of a refactor given my limited familiarity with sorbet.
casperisfine
pushed a commit
to Shopify/sorbet
that referenced
this pull request
Apr 24, 2025
This method was supposed to be deprecated for Ruby 2.7 but fell through the cracks, I'm working on making it happen: ruby/ruby#13157 In addition, Ruby 3.5.0 already has some optimizations in place that are de-optimized if `_id2ref` is ever called: ruby/ruby#13115 And one more issue is that `_id2ref` doesn't work well with ractors. Instead we can hold our own weakmap. It's probably not the ideal implementation, but I chose to not go for too large of a refactor given my limited familiarity with sorbet.
eregon
approved these changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature #15408]
Matz decided to deprecate it for Ruby 2.6 or 2.7 but that never actually happened.
Given the object_id table is a contention point for Ractors it seems sensible to finally deprecate this API so we can generate and store object ids more efficiently in the future.