Skip to content

ZJIT: Split out Send strength reduction into the optimizer #13162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 24, 2025
Merged

ZJIT: Split out Send strength reduction into the optimizer #13162

merged 5 commits into from
Apr 24, 2025

Conversation

tekknolagi
Copy link
Contributor

  • Simplify fixnum guarding code
  • Strength reduce sends on Fixnums in the optimizer instead of HIR builder
  • Make PatchPoint(CalleeModifiedLocals) implicit

@tekknolagi tekknolagi force-pushed the mb-split-send-strength-reduction branch from 28a32a7 to 918c8c2 Compare April 23, 2025 15:14
@launchable-app Launchable app

This comment has been minimized.

Sign in to view
@tekknolagi tekknolagi changed the title Split out Send strength reduction into the optimizer [ZJIT] Split out Send strength reduction into the optimizer Apr 23, 2025
@tekknolagi tekknolagi changed the title [ZJIT] Split out Send strength reduction into the optimizer [zjit] Split out Send strength reduction into the optimizer Apr 23, 2025
@tekknolagi tekknolagi changed the title [zjit] Split out Send strength reduction into the optimizer ZJIT: Split out Send strength reduction into the optimizer Apr 23, 2025
@tekknolagi tekknolagi marked this pull request as ready for review April 23, 2025 16:31
@matzbot matzbot requested a review from a team April 23, 2025 16:31
k0kubun
k0kubun approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@k0kubun k0kubun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tekknolagi tekknolagi force-pushed the mb-split-send-strength-reduction branch from f640fbe to 65efef5 Compare April 23, 2025 20:24
@tekknolagi
Simplify fixnum guarding code
3810ece
@tekknolagi
Strength reduce sends on Fixnums in the optimizer instead of HIR builder
e8c03dd
@tekknolagi
Make PatchPoint(CalleeModifiedLocals) implicit
9500157 
We don't have a good model for modeling weakref-like instruction
dependency behavior and I don't think we should add it just for this.
@tekknolagi
Make type_of use union-find
1e69a0b 
Otherwise we might have stale types floating around
@tekknolagi tekknolagi force-pushed the mb-split-send-strength-reduction branch from 65efef5 to 1e69a0b Compare April 24, 2025 02:33
@tekknolagi tekknolagi force-pushed the mb-split-send-strength-reduction branch from f12a86c to 1b23102 Compare April 24, 2025 16:48
@k0kubun k0kubun merged commit 71166f6 into ruby:master Apr 24, 2025
83 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0kubun k0kubun k0kubun approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tekknolagi @k0kubun