Improve correctness for allocated object counts #13192
Open
+28
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the count of allocated object for a heap is incremented without regards to parallelism which leads to incorrect counts. By maintaining a local counter in the ractor newobj cache, and only syncing atomically with some granularity, we can improve the correctness without increasing contention. The allocated object count is also synced when the ractor is freed. Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
✅ All Tests passed!✖️no tests failed ✔️61953 tests passed(5 flakes) |
|
Thank you, but |
|
I'd like us to consider this anyway. Even if it no longer work once Ractor-local GC is merged, until then fixing Ractor bugs allow us to explore further and find more bugs and issues to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the count of allocated object for a heap is incremented without regards to parallelism which leads to incorrect counts.
Before
After
By maintaining a local counter in the ractor newobj cache, and only syncing atomically with some granularity, we can improve the correctness without increasing contention.
The allocated object count is also synced when the ractor is freed.