ZJIT: Handle ZJIT options properly #13197
Merged
+57
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekknolagi
reviewed
Apr 29, 2025
tekknolagi
reviewed
Apr 29, 2025
tekknolagi
reviewed
Apr 29, 2025
tekknolagi
reviewed
Apr 29, 2025
| help: c_int, highlight: c_int, width: c_uint, columns: c_int); | ||
| } | ||
| let name = CString::new(name).unwrap(); | ||
| let description = CString::new(description).unwrap(); |
There was a problem hiding this comment.
The limitation is more tightly coupled to show_usage_part that formats each line with indentation (we can't even pass 80 cols of description from this function, for example). I would not add such an assertion on this side.
tekknolagi
approved these changes
Apr 29, 2025
XrXr
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR polishes the help and the interface to enable ZJIT.
--zjitfrom--helpwhenUSE_ZJITis 0--jitfor ZJIT-enabled build too--helpjitfeature is turned on and USE_ZJIT is 1RUBY_ZJIT_ENABLEenvironment variable likeRUBY_YJIT_ENABLE