-
Notifications
You must be signed in to change notification settings - Fork 5.4k
ZJIT: Disable ZJIT instructions when USE_ZJIT is 0 #13199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems reasonable. Does this implicitly rely on the zjit instructions a) being contiguous and b) being reliably ordered after all the other instructions? |
Thanks! I was a bit worried about making the interpreter loop function overly big for non users too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, can you toss in a --disable-zjit
build in .github/workflows/compilers.yml
for good measure?
Yes, it does. I added tests for the assumption d67294e. I initially printed
done 932f29c |
As requested by Koichi at RubyKaigi, this PR stops defining ZJIT instructions when ZJIT is disabled for the build.