Fix C23 (GCC 15) WIN32 compatibility for rb_define_* functions #13202
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes [Bug #21286]
✅ All Tests passed!✖️no tests failed ✔️61958 tests passed(3 flakes) |
|
Thanks for this. I just ran it with GCC 15 and it passed. The only warnings were existing digest warnings. See commit for a temporary way to install GCC 15. It adds about 25 seconds to the setup, but given the overall time for the job, it's not bad. The commit removes a 'spacing' blank line, not needed... That time would drop if I make changes as mentioned in the Ruby issue tracker. To lock to a commit for the action, use |
nobu
approved these changes
Apr 30, 2025
Comment on lines
+362
to
+368
| #define rb_define_method(klass, mid, func, arity) rb_define_method((klass), (mid), (VALUE (*)(ANYARGS))(func), (arity)) | ||
| #define rb_define_method_id(klass, mid, func, arity) rb_define_method_id((klass), (mid), (VALUE (*)(ANYARGS))(func), (arity)) | ||
| #define rb_define_singleton_method(obj, mid, func, arity) rb_define_singleton_method((obj), (mid), (VALUE (*)(ANYARGS))(func), (arity)) | ||
| #define rb_define_protected_method(klass, mid, func, arity) rb_define_protected_method((klass), (mid), (VALUE (*)(ANYARGS))(func), (arity)) | ||
| #define rb_define_private_method(klass, mid, func, arity) rb_define_private_method((klass), (mid), (VALUE (*)(ANYARGS))(func), (arity)) | ||
| #define rb_define_module_function(mod, mid, func, arity) rb_define_module_function((mod), (mid), (VALUE (*)(ANYARGS))(func), (arity)) | ||
| #define rb_define_global_function(mid, func, arity) rb_define_global_function((mid), (VALUE (*)(ANYARGS))(func), (arity)) |
There was a problem hiding this comment.
Looks fine, and use RBIMPL_CAST.
Suggested change
| #define rb_define_method(klass, mid, func, arity) rb_define_method((klass), (mid), (VALUE (*)(ANYARGS))(func), (arity)) | |
| #define rb_define_method_id(klass, mid, func, arity) rb_define_method_id((klass), (mid), (VALUE (*)(ANYARGS))(func), (arity)) | |
| #define rb_define_singleton_method(obj, mid, func, arity) rb_define_singleton_method((obj), (mid), (VALUE (*)(ANYARGS))(func), (arity)) | |
| #define rb_define_protected_method(klass, mid, func, arity) rb_define_protected_method((klass), (mid), (VALUE (*)(ANYARGS))(func), (arity)) | |
| #define rb_define_private_method(klass, mid, func, arity) rb_define_private_method((klass), (mid), (VALUE (*)(ANYARGS))(func), (arity)) | |
| #define rb_define_module_function(mod, mid, func, arity) rb_define_module_function((mod), (mid), (VALUE (*)(ANYARGS))(func), (arity)) | |
| #define rb_define_global_function(mid, func, arity) rb_define_global_function((mid), (VALUE (*)(ANYARGS))(func), (arity)) | |
| #define rb_define_method(klass, mid, func, arity) rb_define_method((klass), (mid), RBIMPL_CAST((VALUE (*)(ANYARGS))(func)), (arity)) | |
| #define rb_define_method_id(klass, mid, func, arity) rb_define_method_id((klass), (mid), RBIMPL_CAST((VALUE (*)(ANYARGS))(func)), (arity)) | |
| #define rb_define_singleton_method(obj, mid, func, arity) rb_define_singleton_method((obj), (mid), RBIMPL_CAST((VALUE (*)(ANYARGS))(func)), (arity)) | |
| #define rb_define_protected_method(klass, mid, func, arity) rb_define_protected_method((klass), (mid), RBIMPL_CAST((VALUE (*)(ANYARGS))(func)), (arity)) | |
| #define rb_define_private_method(klass, mid, func, arity) rb_define_private_method((klass), (mid), RBIMPL_CAST((VALUE (*)(ANYARGS))(func)), (arity)) | |
| #define rb_define_module_function(mod, mid, func, arity) rb_define_module_function((mod), (mid), RBIMPL_CAST((VALUE (*)(ANYARGS))(func)), (arity)) | |
| #define rb_define_global_function(mid, func, arity) rb_define_global_function((mid), RBIMPL_CAST((VALUE (*)(ANYARGS))(func)), (arity)) |
There was a problem hiding this comment.
It's not necessary since it's !defined(__cplusplus).
This was referenced Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.