Don't call hash tombstone compaction from GC compaction #13206
Merged
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
reviewed
Apr 29, 2025
byroot
reviewed
Apr 29, 2025
byroot
reviewed
Apr 29, 2025
✅ All Tests passed!✖️no tests failed ✔️61951 tests passed(4 flakes) |
byroot
reviewed
Apr 29, 2025
jeremyevans
approved these changes
Apr 29, 2025
Tombstone removal may possibly require allocation, and we're not allowed to allocate during GC. This commit also renames `set_compact` to `set_update_references` to differentiate tombstone removal compaction with GC object compaction. Co-Authored-By: Max Bernstein <max.bernstein@shopify.com> Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
byroot
reviewed
Apr 29, 2025
| end | ||
|
|
||
| x | ||
| GC.compact |
There was a problem hiding this comment.
Ah mmtk, doesn't have GC.compact:
1) Failure:
TC_Set#test_set_gc_compact_does_not_allocate [/Users/runner/work/ruby/ruby/src/test/ruby/test_set.rb:869]:
pid 52362 exit 1
| -:8:in '<main>': compact() function is unimplemented on this machine (NotImplementedError)
| from -:8:in '<main>'
.
Sorry for suggesting that change :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tombstone removal may possibly require allocation, and we're not allowed to allocate during GC. This commit also renames
set_compacttoset_gc_compactto differentiate tombstone removal compaction with GC object compaction.