Fix heap-use-after-free
in free_fast_fallback_getaddrinfo_entry
#13231
+17
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses the following ASAN error:
A
struct fast_fallback_getaddrinfo_shared
is shared between the main thread and two child threads. This struct contains an array offast_fallback_getaddrinfo_entry
.fast_fallback_getaddrinfo_entry
andfast_fallback_getaddrinfo_shared
were freed separately, and iffast_fallback_getaddrinfo_shared
was freed first and then an attempt was made to free afast_fallback_getaddrinfo_entry
, aheap-use-after-free
could occur.This change avoids that possibility by separating the deallocation of the addrinfo memory held by
fast_fallback_getaddrinfo_entry
from the access and lifecycle of thefast_fallback_getaddrinfo_entry
itself.