Introduce an "Inline IVAR cache" struct #2697
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ko1
reviewed
Nov 27, 2019
| @@ -16,6 +16,7 @@ | |||
| "CDHASH" => %w[H TS_CDHASH], | |||
| "GENTRY" => %w[G TS_GENTRY], | |||
| "IC" => %w[K TS_IC], | |||
There was a problem hiding this comment.
Do you have a suggestion? IC is still used for opt_getinlinecache and opt_setinlinecache
Lines 1038 to 1062 in e530cfd
I could rename, but IC matches the instruction names.
There was a problem hiding this comment.
reading related code, we need to refactoring overall. I'll do it so you don't need to change them. thanks.
|
|
62c89fd to
69d0c27
Compare
69d0c27 to
772f882
Compare
This commit introduces an "inline ivar cache" struct. The reason we need this is so compaction can differentiate from an ivar cache and a regular inline cache. Regular inline caches contain references to `VALUE` and ivar caches just contain references to the ivar index. With this new struct we can easily update references for inline caches (but not inline var caches as they just contain an int)
772f882 to
1a7bf3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces an "inline ivar cache" struct. The reason we
need this is so compaction can differentiate from an ivar cache and a
regular inline cache. Regular inline caches contain references to
VALUEand ivar caches just contain references to the ivar index. Withthis new struct we can easily update references for inline caches (but
not inline var caches as they just contain an int)