Share extracted bundled gems with gems for bundler #2922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract bundled gems under ".bundle/gems" and get rid of duplication which cause constant redefinition warnings at `test-all` after `extract-gems` and `test-bundler`.
hsbt
approved these changes
Feb 24, 2020
|
I don't understand what is the purpose of this PR, but it seems to me, that now, the gems are installed from the .gem packages instead from their unpacked versions (the tarball ships both). This results in wrong shebang in "rake" binary, because |
|
Just FTR, shipping the .gem packages as well as their unpacked counterparts always felt strange to me. |
voxik
added a commit
to voxik/ruby
that referenced
this pull request
Feb 27, 2020
The missing `\` in PR ruby#2922 causes the default gems to be installed from the .gem packages instead from the expanded sources.
Merged
nobu
pushed a commit
that referenced
this pull request
Feb 28, 2020
The missing `\` in PR #2922 causes the default gems to be installed from the .gem packages instead from the expanded sources.
nobu
pushed a commit
to nobu/ruby
that referenced
this pull request
Apr 1, 2022
The expanded gem location changed from 'gem' to '.bundled/gems' directory in commit:git|55bf0ef1aa7c936b564b883196de1ace4be4cc7e / ruby#2922, leaving behind binary extension installation. This should fix the issues, so the gem binary extensions are buildable as part of Ruby build process again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract bundled gems under ".bundle/gems" and get rid of duplication which cause constant redefinition warnings at
test-allafterextract-gemsandtest-bundler.