Fix rbinstall bugs #2930
Merged
Fix rbinstall bugs #2930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd77ec to
5c190e4
Compare
Merged
voxik
reviewed
Feb 27, 2020
5c190e4 to
9ce701c
Compare
This method doesn't take keyword args.
Now `Gem.ensure_gem_subdirectories` is doing its job, so some stuff is no longer needed.
9ce701c to
3024424
Compare
4 tasks
|
The bad regexp was fixed via #2933, so this PR now includes only the changes related to the bad |
|
@hsbt Could you review this if you have time? |
|
@deivid-rodriguez Sure, I will review and merge this at Friday this week. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a couple of bugs in
rbinstall.rb, so I fixed them:Gem.ensure_gem_subdirectoriesdoes not take keyword args. The error was being swallowed, but I'm fixing that in rubygems. This bugfix allows to simplify some code.One regexp was missing a
\escape character. Merged through Fix wrong RegExp. #2933.