Use native thread locals. #3665
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c77dcc7 to
c9a6f44
Compare
|
@ko1 it seems segfault with mjit. Do you have any idea why? No function is changed. |
6d3716b to
22f32f5
Compare
22f32f5 to
7596105
Compare
ko1
added a commit
to ko1/ruby
that referenced
this pull request
Oct 19, 2020
To access TLS, it is faster to use language TLS specifier instead of using pthread_get/setspecific functions. Original proposal is: Use native thread locals. ruby#3665
ko1
added a commit
to ko1/ruby
that referenced
this pull request
Oct 19, 2020
To access TLS, it is faster to use language TLS specifier instead of using pthread_get/setspecific functions. Original proposal is: Use native thread locals. ruby#3665
|
Closing in favour of @ko1 PR. |
ko1
added a commit
to ko1/ruby
that referenced
this pull request
Oct 19, 2020
To access TLS, it is faster to use language TLS specifier instead of using pthread_get/setspecific functions. Original proposal is: Use native thread locals. ruby#3665
ko1
added a commit
to ko1/ruby
that referenced
this pull request
Oct 19, 2020
To access TLS, it is faster to use language TLS specifier instead of using pthread_get/setspecific functions. Original proposal is: Use native thread locals. ruby#3665
ko1
added a commit
that referenced
this pull request
Oct 19, 2020
To access TLS, it is faster to use language TLS specifier instead of using pthread_get/setspecific functions. Original proposal is: Use native thread locals. #3665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using native thread locals, we can regain most of the lost performance.
compare-rubyis one commit beforeractorwas merged.built-rubyis this PR on master.masterwas around 7.5m on my computer.However, I experienced some segfault, but I don't know why yet. The implementation is not changed. Maybe there is race condition.