Skip to content

Fix some compiler errors #4457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2021
Merged

Conversation

peterzhu2118
Copy link
Member

This PR will fix some of the compiler errors on master.

ENUM_OVER_INT is sometimes not defined. Use #ifdef instead if #if.
__LITTLE_ENDIAN is not defined.
__FreeBSD_version is defined in sys/param.h.
USE_WIN32_MUTEX flag may not be defined.
@ko1
Copy link
Contributor

ko1 commented Nov 9, 2021

Sorry which compiler shows compile errors?
https://stackoverflow.com/questions/5085392/what-is-the-value-of-an-undefined-constant-used-in-if

or we introduced some warning option to prohibit such cases?

@peterzhu2118
Copy link
Member Author

@ko1 #4428 added -Werror=undef during compilation.

@ko1
Copy link
Contributor

ko1 commented Nov 9, 2021

Thank you!

maybe USE_WIN32_MUTEX should be 0/1 macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants