Skip to content

.github/workflows/compilers.yml: support GCC-11 #4484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2021

Conversation

shyouhei
Copy link
Member

@shyouhei shyouhei requested a review from junaruga May 10, 2021 03:30
@shyouhei shyouhei marked this pull request as ready for review May 10, 2021 03:41
@shyouhei shyouhei changed the title .github/compilers/workflows.yml: support GCC-11 .github/workflows/compilers.yml: support GCC-11 May 10, 2021
Copy link
Member

@junaruga junaruga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks amazing! A only small issue is I find tailing spaces in ruby-ci-image assets/*.list files, could you fix it? I also commented some things there. Thanks!

Copy link
Member

@junaruga junaruga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR. The thing I I said is related to the ruby-ci-image's PR.

@shyouhei shyouhei merged commit 4785d60 into ruby:master May 11, 2021
@shyouhei shyouhei deleted the gcc-11 branch July 4, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants