Finish adding support for AES-CCM mode #569
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add #ossl_is_ccm macro for AES-128-CCM, AES-192-CCM and AES-256-CCM - Modify OpenSSL::Cipher#authenticated? to return true for CCM modes - Add ossl_ccm_set_auth_tag and ossl_ccm_get_auth_tag methods - Modify OpenSSL::Cipher#auth_tag and OpenSSL::Cipher#auth_tag= to support CCM - Add OpenSSL::Cipher#iv_len= method to support non-standard CCM IV lengths - Add some documentation on how to use non-standard CCM IV lengths
|
Does anyone have pointers as to what is missing for this PR to be considered for inclusion? |
|
@louismullie This needs approval of @emboss |
|
@nahi Can you review this? |
|
I'm not sold on this patch, and releasing "as-is" is taking priority at the moment. I also think making |
|
OpenSSL needs to know the plaintext length before setting the AAD or starting encrypting. So if we want support AES-CCM in OpenSSL::Cipher, we need another method #plaintext_len=, and of course this is a very bad idea. |
rhenium
added a commit
to rhenium/ruby-openssl
that referenced
this pull request
Jul 3, 2016
Add OpenSSL::Cipher#iv_len=. For interoperability with other applications, it is sometimes required. Normally 'IV' is fixed-length, but in OpenSSL, some ciphers such as aes-128-gcm make use of it as 'nonce', which is variable-length. Changing the IV length in Cipher#iv= is also an option but I decided not to choose it. Because in Ruby <= 2.3 Cipher#iv= truncates the input when the length is longer than the current IV length, changing the behavior might cause unexpected encryption result. [Bug #8667] [Bug #10420] [GH ruby/ruby#569]
rhenium
added a commit
to rhenium/ruby-openssl
that referenced
this pull request
Jul 9, 2016
Add OpenSSL::Cipher#iv_len=. For interoperability with other applications, it is sometimes required. Normally 'IV' is fixed-length, but in OpenSSL, some ciphers such as aes-128-gcm make use of it as 'nonce', which is variable-length. Changing the IV length in Cipher#iv= is also an option but I decided not to choose it. Because in Ruby <= 2.3 Cipher#iv= truncates the input when the length is longer than the current IV length, changing the behavior might cause unexpected encryption result. [Bug #8667] [Bug #10420] [GH ruby/ruby#569]
nov
added a commit
to nov/apple_pay
that referenced
this pull request
Oct 5, 2016
ruby openssl itself needs to be updated to support OpenSSL::Cipher#iv_len= ruby/ruby#569 ApplePay uses 16 as iv_len, not ruby default's 12.
|
As commented before, CCM does not fit with the interface of OpenSSL::Cipher. Please open a new issue at https://github.com/ruby/openssl if you have ideas about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only the GCM mode of authenticated encryption is supported in Ruby. This patch adds support for the CCM mode of authenticated encryption. It also adds support for explicitly setting IV length, which is required by OpenSSL when dealing with non-standard IV lengths in CCM mode. See https://bugs.ruby-lang.org/issues/9642 for more information.
More details:
support CCM
lengths