YJIT: Reduce Rust version requirement to 1.58.1 #5951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to make it convenient for people to build YJIT and >=1.58.1 is available on the Ubuntu Jammy, Debian testing, and Fedora 36 through the usual package manager on those systems. This saves the need to install `rustup` for some people. Our code is already 1.58.1 compatible so this commit simply tweaks CI to make sure that we keep supporting the version. We still test against the latest Rust version in `--enable-yjit=dev` builds through the Rust version available in GitHub's CI image. Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>
maximecb
approved these changes
May 27, 2022
|
From the description, it's not clear to me whether older versions of Rust are also supported, and if yes, which versions. For example, Ubuntu 20.04 comes with Rust 1.57.0. Is that okay for YJIT? |
|
We are only supporting 1.58.1 and above for now. We don't test on 1.57.0 so future code changes might break it even if it builds today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make it convenient for people to build YJIT and >=1.58.1 is
available on Ubuntu Jammy, Debian testing, and Fedora 36 through the
usual package manager on those systems. This saves the need to install
rustupfor some people.Our code is already 1.58.1 compatible so this commit simply tweaks CI
to make sure that we keep supporting the version. We still test against
the latest Rust version in
--enable-yjit=devbuilds through the Rustversion available in GitHub's CI image.