Skip to content

YJIT: Fix a wrong type reference #6661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Nov 2, 2022

found a typo in #6640 🙇

@matzbot matzbot requested a review from a team November 2, 2022 17:03
@XrXr
Copy link
Member

XrXr commented Nov 2, 2022

Though I don't really understand why there is a distinction between the two self types. Do we use this captured_self_type field outside of the logic for invoke block? It seems like code inside the block would use the regular self_type.
It looks like in the PR we never upgrade the type with CapturedSelfOpnd, so it should always be Unknown

@k0kubun
Copy link
Member Author

k0kubun commented Nov 2, 2022

Hmm, yeah. I thought it could be useful when calling yield in two places, but in reality I didn't add any code for upgrading CapturedSelfOpnd. The initial reason to add this was to avoid a crash on StackOpnd(argc.try_into().unwrap()), so I could just directly fix it and leave captured->self type profiling not supported for now, assuming we often can't upgrade the type anyway.

@k0kubun
Copy link
Member Author

k0kubun commented Nov 2, 2022

addressed it in 38a6370

@maximecb maximecb merged commit 124f10f into ruby:master Nov 3, 2022
@maximecb maximecb deleted the yjit-fix-typo branch November 3, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants