Skip to content

IO.pipe should be non-blocking by default, even on Windows. #6874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

IO.pipe should be non-blocking by default, even on Windows. #6874

wants to merge 1 commit into from

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Dec 7, 2022 •
edited
Loading

@larskanis what do you think of this?

@ioquatix ioquatix mentioned this pull request Dec 7, 2022
Draft
4 tasks
@ioquatix ioquatix force-pushed the io-windows-nonblocking branch from 9612cd4 to 5fcf143 Compare December 8, 2022 00:59
@ioquatix ioquatix mentioned this pull request Dec 8, 2022
Open
@larskanis
Copy link
Contributor

Actually I started to work on this a while ago, but didn't complete it. Here is my branch: https://github.com/ruby/ruby/compare/master...larskanis:ruby:nonblock?expand=1

@ioquatix
Copy link
Member Author

ioquatix commented Dec 8, 2022 •
edited
Loading

Any chance I can help you hack this to completion? It's needed for good (well, the best we can do) Async support on Windows.

@ioquatix
Copy link
Member Author

#6897

@ioquatix ioquatix mentioned this pull request Dec 13, 2022
Open
@ioquatix ioquatix force-pushed the io-windows-nonblocking branch from 5fcf143 to d035d01 Compare December 17, 2022 20:43
@hsbt hsbt force-pushed the io-windows-nonblocking branch from d035d01 to ebfef19 Compare September 20, 2024 02:31
@ioquatix ioquatix mentioned this pull request Apr 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ioquatix @larskanis