add timing-safe hmac verify method #688
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could be totally wrong, but it seems the standard library doesn't provide a reliable way of comparing hashes in constant-time.
Digest#to_s.With this patch I propose to add an additional method,
OpenSSL::HMAC#verify, which takes a binary string with a digest and compares it against the computed hash.I've also logged a feature request at https://bugs.ruby-lang.org/issues/10098 - since this is my first time contributing I'm not sure what constitutes a "tiny fix"; here's a pull request too.