Ractor.make_shareable(proc_obj) makes inner structure shareable #7182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
368f1cf to
9c72957
Compare
Proc objects are now traversed like other objects when making them shareable. Fixes [Bug #19372] Fixes [Bug #19374]
9c72957 to
41e6cdd
Compare
jhawthorn
reviewed
Mar 24, 2025
| @@ -1284,6 +1284,7 @@ rb_proc_ractor_make_shareable(VALUE self) | |||
| } | |||
|
|
|||
| FL_SET_RAW(self, RUBY_FL_SHAREABLE); | |||
There was a problem hiding this comment.
I think because we're eagerly setting the flag here, this branch has the same issue as before (but it just needs two attempts 😅)
y = nil.instance_eval do
foo = []
proc { foo }.curry
end
begin
Ractor.make_shareable(y)
rescue => e
p exception: e
end
# => {exception: #<Ractor::IsolationError: can not make shareable Proc because it can refer unshareable object [] from variable 'foo'>}
p shareable: Ractor.make_shareable(y)
# => {shareable: #<Proc:0x00007cc25b895760>}
# No error!
p y.call.frozen? # => falseThere was a problem hiding this comment.
I rebased and removed this flag set in 53b93d4 and I think that still does what's intended
This was referenced Mar 24, 2025
|
This was merged in #12977 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proc objects are now traversed like other objects when making them shareable.
Fixes [Bug #19372]
https://bugs.ruby-lang.org/issues/19372