Skip to content

Hide the usage of rb_io_t where possible. #7880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2023
Merged

Hide the usage of rb_io_t where possible. #7880

merged 1 commit into from
Jun 1, 2023

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Jun 1, 2023 •
edited
Loading

This is purely the additive parts of the previous PR, which caused downstream compatibility issues, #6511

This introduces the minimum amount of public interface for avoiding accessing rb_io_t internals in most cases.

@ioquatix ioquatix requested review from nurse and eregon June 1, 2023 02:27
@ioquatix ioquatix force-pushed the io-hide-implementation-part1 branch 8 times, most recently from 741720e to bca4981 Compare June 1, 2023 03:54
@noteflakes noteflakes mentioned this pull request Jun 1, 2023
Closed
@ioquatix ioquatix force-pushed the io-hide-implementation-part1 branch from bca4981 to c990867 Compare June 1, 2023 04:52
@ioquatix ioquatix merged commit a218ed5 into ruby:master Jun 1, 2023
@ioquatix ioquatix deleted the io-hide-implementation-part1 branch June 1, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon left review comments

@nurse nurse Awaiting requested review from nurse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ioquatix @eregon