Introduce enum rb_io_mode.
#7894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why need to add #ifndef HAVE_TYPE_RB_IO_MODE
typedef int rb_io_mode;
#endifOr have_type("rb_io_mode") or $defs << "-Drb_io_mode=int" |
|
Ah yes, that's a great idea, thanks. |
35414a5 to
4b48e24
Compare
✅ All Tests passed!✖️no tests failed ✔️61933 tests passed(1 flake) |
|
Upstream changes to |
nobu
approved these changes
Apr 15, 2025
kou
pushed a commit
to ruby/stringio
that referenced
this pull request
Apr 15, 2025
Companion PR to <ruby/ruby#7894>.
matzbot
pushed a commit
that referenced
this pull request
Apr 15, 2025
(ruby/stringio#129) Companion PR to <#7894>. ruby/stringio@2d3988e12f
68a7153 to
a8903db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice if auto-complete worked correctly, and we got a little more type-checking from the compiler.
ruby/stringiofirst.