Skip to content

YJIT: Make yjit_alloc_size available by default #8426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2023
Merged

YJIT: Make yjit_alloc_size available by default #8426

merged 1 commit into from
Sep 13, 2023

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Sep 13, 2023

yjit_alloc_size is a very important metric for monitoring YJIT since it's more significant than code_region_size in production, but this is available only with --enable-yjit=stats. This PR proposes to make it available by default.

The performance impact on the 1st iteration of the following benchmarks doesn't seem too significant:

before: ruby 3.3.0dev (2023-09-12T21:45:26Z master 19346c2336) +YJIT [x86_64-linux]
after: ruby 3.3.0dev (2023-09-13T00:43:05Z yjit-stats-alloc af1b1f5d02) +YJIT [x86_64-linux]

-----------  -----------  ----------  ----------  ----------  -------------  ------------
bench        before (ms)  stddev (%)  after (ms)  stddev (%)  after 1st itr  before/after
lobsters     1751.9       0.0         1753.9      0.0         1.00           1.00
railsbench   1503.5       0.0         1492.0      0.0         1.01           1.01
30k_ifelse   1373.7       0.0         1385.9      0.0         0.99           0.99
30k_methods  917.4        0.0         930.3       0.0         0.99           0.99
-----------  -----------  ----------  ----------  ----------  -------------  ------------

@matzbot matzbot requested a review from a team September 13, 2023 00:59
@maximecb maximecb merged commit ff329ce into ruby:master Sep 13, 2023
@k0kubun k0kubun deleted the yjit-stats-alloc branch September 13, 2023 16:30
@k0kubun k0kubun mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k0kubun @maximecb