Thread events hooks: Pass concerned Thread to callbacks #8605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let Thread event callback functions receive VALUE thread in concern. This will be a more stable way than calling gettid(2) in callbacks.
nobu
reviewed
Oct 9, 2023
Comment on lines
+2454
to
+2455
| rb_internal_thread_event_data_t *data = ALLOC_N(rb_internal_thread_event_data_t, 1); | ||
| data->thread = th->self; |
There was a problem hiding this comment.
Why dynamically allocating?
This seems a memory leak.
Suggested change
| rb_internal_thread_event_data_t *data = ALLOC_N(rb_internal_thread_event_data_t, 1); | |
| data->thread = th->self; | |
| rb_internal_thread_event_data_t data[1] = {{.thread = th->self}}; |
|
This was added in a separate PR so this should no longer be necessary #8885 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let Thread event callback functions receive VALUE thread in concern. This will be a more stable way than calling gettid(2) in callbacks.