Skip to content

Remove not used fields from MATCH #8620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Remove not used fields from MATCH #8620

wants to merge 4 commits into from

Conversation

yui-knk
Copy link
Contributor

@yui-knk yui-knk commented Oct 10, 2023

No description provided.

@yui-knk yui-knk requested a review from nobu October 10, 2023 22:51
@yui-knk
Copy link
Contributor Author

yui-knk commented Oct 16, 2023

Based on @nobu 's suggestion, I decide to keep to use nd_set_type if both nodes have same structure or new type node has less members than original node.
Clean up of not_used members were done by #8662, then I will close this PR.

@yui-knk yui-knk closed this Oct 16, 2023
@yui-knk yui-knk deleted the refactor_node_match branch October 16, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobu nobu Awaiting requested review from nobu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yui-knk