YJIT: Skip dump-disasm if it fails to create a file #8968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes set
--yjit-dump-disasm=/buildkite-artifactsin a bash script that is shared everywhere (CI & production) to configure YJIT so that disasm shows up as Artifacts on Buildkite. However, because this directory is specific to some CI workflows and the directory doesn't necessarily exist, it could crash on such workflows.Panicking the Ruby because it failed to disasm YJIT code seems extreme, so this PR fixes it to only warn that it failed to create a file. It would help us easily add such options on CI without complicating the logic to skip it for some workflows.