🐛 Fixes [Bug #20039](https://bugs.ruby-lang.org/issues/20039) #9120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
approved these changes
Dec 4, 2023
nobu
reviewed
Dec 5, 2023
nobu
reviewed
Dec 5, 2023
test/ruby/test_regexp.rb
Outdated
Comment on lines
1943
to
1944
| str.match?(re) | ||
| str.match?(Regexp.new(re)) |
There was a problem hiding this comment.
Needs assertions, or should comment that we expect no exception here, at least.
There was a problem hiding this comment.
Thank you for the feedback. I changed this to use assert_nothing_raised.
27d1d18 to
f0dc0eb
Compare
When a Regexp is initialized with another Regexp, we simply copy the properties from the original. However, the flags on the original were not being copied correctly. This caused an issue when the original had multibyte characters and was being compared with an ASCII string. Without the forced encoding flag (`KCODE_FIXED`) transferred on to the new Regexp, the comparison would fail. See the included test for an example.
f0dc0eb to
7b917dc
Compare
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Regexp is initialized with another Regexp, we simply copy the properties from the original. However, the flags on the original were not being copied correctly. This caused an issue when the original had multibyte characters and was being compared with an ASCII string. Without the forced encoding flag (
KCODE_FIXED) transferred on to the new Regexp, the comparison would fail. See the included test for an example.