Make the SHAPE_TOO_COMPLEX performance warning more actionable #9275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested by Mame, we should try to help users fix the issues without having to lookup the meaning of the warning.
35ca889 to
5a0e4ae
Compare
mame
approved these changes
Dec 18, 2023
eregon
reviewed
Dec 18, 2023
| SHAPE_MAX_VARIATIONS, | ||
| rb_class_path(klass) | ||
| "The class %"PRIsVALUE" reached %d shape variations, instance variables accesses will be slower and memory usage increased.\n" | ||
| "It is recommended to define instance variable in a consistent order, for instance by eagerly defining them all in the `initialize` method.", |
There was a problem hiding this comment.
Minor, but backquotes seem rare in Ruby exception/warning messages, here I think #initialize would be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @mame, we should try to help users fix the issues without having to lookup the meaning of the warning.