Fix issues with Ractor#send with move option for Array/Hash/Struct #9475
Conversation
|
WIP for now, I'm exporting some weird symbols in internal/hash.h for instance. Edit: fixed the issues mentioned in this comment. Also, now hides rec_hash from objectspace. |
e940870 to
cb82923
Compare
Array/Hash/Struct were not being moved properly. If arrays were embedded they weren't being moved. Hashes were not being updated properly and write barriers were not being fired on newly moved object. Structs fields were not being set properly. Also fix issue where moved object_id was different from original object's object id. Fixes [Bug #20165]
cb82923 to
eff9423
Compare
Why is this? Just from reading the patch I don't understand why they need to be unembedded to move. It seems like we'd want to keep embedded arrays embedded (since its a nice optimization) |
|
Yeah I agree about keeping arrays embedded. I was just creating a first pass at getting things correct, then I wanted to look into keeping the optimizations. With the way that objects are moved now, this seemed like the easy way to get it to work. For embedded arrays, I still need to look into how to copy them as I'm unfamiliar with how they work exactly (for example, if all arrays have the same embedded size, or if different objects in different size pools have different capacities). In reviewing this PR though, there are other issues other than the arrays (memory leak issues), so I think I'll close this PR and put the object_id stuff in a separate pull request. Then when I have time I'll look into doing these fixes properly. |
Array/Hash/Struct were not being moved properly. If arrays were embedded they weren't being moved. Hashes were not being updated properly and write barriers were not being fired on newly moved object. Structs fields were not being set properly.
Also fix issue where moved object_id was different from original object's object id.
Fixes [Bug #20165]