Fix linting line end #9518
Closed
Fix linting line end #9518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you mean by "It crashes"? It seems to exit with an error as expected. |
|
I tried with ruby v2.7.8, but a colleague of mine told me that the newest version still crashes. Maybe it was a mistake and it does not crash. Still, I can't understand why it crashes, why |
|
Here is code which makes latest ruby master (from commit 0520e96) crash in the same code paths: Backtrace from gdb: (gdb) bt
#0 0x000055555575802b in ruby_each_words (str=0xe791 <error: Cannot access memory at address 0xe791>, func=func@entry=0x5555556e4f60 <disable_option>, arg=arg@entry=0x7fffffffdca0)
at util.c:599
#1 0x00005555556e7535 in proc_long_options (envopt=0, envopt@entry=<error reading variable: dwarf2_find_location_expression: Corrupted DWARF expression.>, argv=<optimized out>,
argc=<optimized out>, s=<optimized out>, opt=0x7fffffffdc50, opt@entry=<error reading variable: dwarf2_find_location_expression: Corrupted DWARF expression.>) at ruby.c:1400
#2 proc_options (argc=<optimized out>, argv=<optimized out>, opt=0x7fffffffdc50, envopt=0) at ruby.c:1694
#3 0x00005555556e7f21 in moreswitches (s=<optimized out>, opt=opt@entry=0x7fffffffdc50, envopt=envopt@entry=0) at ruby.c:933
#4 0x00005555556e89e6 in load_file_internal (argp_v=argp_v@entry=140737488341264) at ruby.c:2571
#5 0x0000555555597ba9 in rb_ensure (b_proc=b_proc@entry=0x5555556e8710 <load_file_internal>, data1=data1@entry=140737488341264, e_proc=e_proc@entry=0x5555556e4df0 <restore_load_file>,
data2=data2@entry=140737488341264) at eval.c:1009
#6 0x00005555556ea3ec in load_file (opt=<error reading variable: dwarf2_find_location_expression: Corrupted DWARF expression.>,
script=<error reading variable: dwarf2_find_location_expression: Corrupted DWARF expression.>, f=<error reading variable: dwarf2_find_location_expression: Corrupted DWARF expression.>,
fname=<error reading variable: dwarf2_find_location_expression: Corrupted DWARF expression.>,
parser=<error reading variable: dwarf2_find_location_expression: Corrupted DWARF expression.>) at ruby.c:2760
#7 process_options (argc=0, argv=<optimized out>, opt=0x7fffffffdc50) at ruby.c:2296
#8 0x00005555556eaea8 in ruby_process_options (argc=argc@entry=2, argv=argv@entry=0x7fffffffdf18) at ruby.c:229
#9 0x00005555555968df in ruby_options (argc=2, argv=0x7fffffffdf18) at eval.c:121
#10 0x00005555555916eb in rb_main (argv=<error reading variable: dwarf2_find_location_expression: Corrupted DWARF expression.>,
argc=<error reading variable: dwarf2_find_location_expression: Corrupted DWARF expression.>) at ./main.c:39
#11 main (argc=<optimized out>, argv=<optimized out>) at ./main.c:58 |
|
PR about |
str is an array, but *str points to its beginning, that does not make sense and will never be true. Fixes: 989a6f1 ("ruby.c: simplify")
|
Closed by #9575 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
str is an array, but
*strpoints to its beginning, that does not make sense and will never be true.Fixes: 989a6f1 ("ruby.c: simplify")
I am not sure that this patch is correct!
I came across this code while debugging the following crash:
create a file with the following line:
#!ruby --enableand run:
ruby fileIt crashes. This patch does not fix this crash, but I came across the changed code while debugging it...