Better handling of timeout in rb_io_maybe_wait_*.
#9531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2f20e7a to
a8415ec
Compare
9d7554b to
857cab8
Compare
7d719d9 to
ed683fe
Compare
ed683fe to
90ab45c
Compare
This comment has been minimized.
This comment has been minimized.
f713bfb to
8819cd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some investigation, I believe this is a safe and effective change to introduce timeouts.
I have experimental PR for OpenSSL ruby/openssl#714 which is compatible with this change but allows us to get timeouts without major Ruby version bump. Both can be merged, but this is a more general approach.