-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Rewrite Numeric#times in Ruby using Primitive #9576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
4591663
to
0973f5d
Compare
The order of iseq may differ from the order of tokens.
0973f5d
to
d07f9f0
Compare
Can you clarify the motivation? I don't think Matz asked for it https://bugs.ruby-lang.org/issues/20182#note-5:
I'm fine with replacing |
This was just an experiment, but I found that builtin-indexes were not working with |
It'd be nice to have those builtin index fixes 👍 |
Are you OK with the restriction, |
Yeah, I'm fine with it as long as it gives an error on conflict. RJIT is an exception, but it'd usually mean that you should merge such primitives. |
No description provided.