Skip to content

[PRISM] Check keyword parameters correctly #9656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2024
Merged

[PRISM] Check keyword parameters correctly #9656

merged 2 commits into from
Jan 23, 2024

Conversation

tenderlove
Copy link
Member

We weren't checking the right offsets when compiling methods with keyword parameters that had complex code.

Fixes: ruby/prism#2228

@tenderlove tenderlove force-pushed the kw-param-check branch 2 times, most recently from 8be9d12 to e250fd7 Compare January 22, 2024 23:02
@tenderlove tenderlove enabled auto-merge (rebase) January 22, 2024 23:02
@tenderlove
Check keyword parameters correctly
0e14648 
We weren't checking the right offsets when compiling methods with
keyword parameters that had complex code.

Fixes: ruby/prism#2228
@tenderlove tenderlove merged commit f423ced into ruby:master Jan 23, 2024
@tenderlove tenderlove deleted the kw-param-check branch January 23, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method calls in keyword parameter defaults
1 participant
@tenderlove