Bundle rbs-3.4.3 #9702
Merged
Bundle rbs-3.4.3 #9702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31fcd08 to
1d2a3d5
Compare
Allow typeprof test failures
1d2a3d5 to
72ceb51
Compare
|
typeprof is still failing, but it's ignored: It looks like unrelated to rbs update. So leaving it for @mame. 🙏 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating bundled rbs to 3.4.3 introduced a test failure.
test_loading_from_rbs_collection__gem_version_mismatch(RBS::EnvironmentLoaderTest)is failing because it requiresrbs-ambergem, which is generated during tests into Bundler context. Since the test is running without Bundler, it should be skipped. (This is a test case added in rbs-3.4.3, so it's a bug of rbs-3.4.3...)test_argument_forwarding(RBS::RbPrototypeTest), which is introduced during recent parser changes. So, I'm just moving the ignore fromTEST_BUNDLED_GEMS_ALLOW_FAILURESto more fine grainedrbs_skip_tests. We will enable the tests before Ruby 3.4 release, once the parser got stable enough.