Don't wait in io_binwrite_string if not necessary.
#9792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
Don't wait in `io_binwrite_string` if not necessary. (#9792) --- io.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
nagachika
added a commit
to nagachika/ruby
that referenced
this pull request
Mar 31, 2024
Don't wait in `io_binwrite_string` if not necessary. (ruby#9792) --- io.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.ruby-lang.org/issues/20231
Indirectly responsible for socketry/async#301.
Writing to a buffered IO can result in the entire internal buffer being flushed, which causes
io_binwrite_string_internalto return 0. In that case, we were settingerrno = EAGAIN. This causesrb_io_maybe_wait_writableto be invoked, however we should immediately retryio_binwrite_string_internalinstead, which is what this proposal implements.The reason why calling
rb_io_maybe_wait_writableis a bad idea in general, is that not all IO can go via this mechanism - in other words,kqueuedoes not supportkevent("/dev/null", writable)and returns errno=22EINVAL. The same applies to some kinds of pipes, TTYs, etc.