Skip to content

merge revision(s) 1bd98c820da46a05328d2d53b8f748f28e7ee8f7: [Backport #20172] #9798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2024

Conversation

nurse
Copy link
Member

@nurse nurse commented Feb 1, 2024

Remove setaffinity of pthread for getaddrinfo

It looks like `sched_getcpu(3)` returns a strange number on some
(virtual?) environments.

I decided to remove the setaffinity mechanism because the performance
does not appear to degrade on a quick benchmark even if removed.

[Bug #20172]
---
 ext/socket/extconf.rb  |  2 --
 ext/socket/raddrinfo.c | 48 ++++--------------------------------------------
 2 files changed, 4 insertions(+), 46 deletions(-)

	Remove setaffinity of pthread for getaddrinfo

	It looks like `sched_getcpu(3)` returns a strange number on some
	(virtual?) environments.

	I decided to remove the setaffinity mechanism because the performance
	does not appear to degrade on a quick benchmark even if removed.

	[Bug #20172]
	---
	 ext/socket/extconf.rb  |  2 --
	 ext/socket/raddrinfo.c | 48 ++++--------------------------------------------
	 2 files changed, 4 insertions(+), 46 deletions(-)
@nurse nurse enabled auto-merge February 1, 2024 08:15
@nurse nurse added this pull request to the merge queue Feb 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 1, 2024
@nurse nurse added this pull request to the merge queue Feb 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 2, 2024
@nurse nurse enabled auto-merge February 3, 2024 15:11
@nurse nurse added this pull request to the merge queue Feb 3, 2024
Merged via the queue into ruby:ruby_3_3 with commit 53d4e9c Feb 3, 2024
@nurse nurse deleted the backport-20172 branch February 3, 2024 17:57
@hsbt hsbt added the Backport label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants