Skip to content

Fix test session reuse but expire #9824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2024
Merged

Fix test session reuse but expire #9824

merged 2 commits into from
Feb 3, 2024

Conversation

nurse
Copy link
Member

@nurse nurse commented Feb 3, 2024

@nurse nurse enabled auto-merge February 3, 2024 11:24
@nurse nurse added this pull request to the merge queue Feb 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 3, 2024
@nurse nurse added this pull request to the merge queue Feb 3, 2024
Merged via the queue into ruby:ruby_3_3 with commit 4506461 Feb 3, 2024
@nurse nurse deleted the fix-test_session_reuse_but_expire branch February 3, 2024 14:51
@nurse nurse mentioned this pull request Feb 5, 2024
Merged
matzbot pushed a commit that referenced this pull request Feb 7, 2024
@nurse @nobu
Fix test session reuse but expire (#9824)
64b6a01 
* OpenSSL 3.2.1 30 Jan 2024 is also broken

Import 4506461 from ruby_3_3 branch
tentatively.
@voxik
Copy link
Contributor

voxik commented Mar 6, 2024

Is there by a chance more details what is the root of the issue? Was it reported upstream? I am asking because we are facing the same issue on Fedora, therefore I have found this patch, but it does not really explain much :/

@voxik
Copy link
Contributor

voxik commented Mar 6, 2024

Just looking at #9036 which originally disabled the test case, there is even less details :/

This was referenced Mar 14, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 14, 2024
@nurse
Fix test session reuse but expire (#9824) (#10250)
2a84aaf 
merge revision(s) 596db9c: [Backport #20090]

	[Feature #19370] Blocks without anonymous parameters should not
	 affect

	---
	 parse.y                  | 4 ++--
	 test/ruby/test_syntax.rb | 7 +++++++
	 2 files changed, 9 insertions(+), 2 deletions(-)
matzbot pushed a commit that referenced this pull request Mar 21, 2024
@nagachika
merge revision(s) 64b6a01:
0a2238d 
	Fix test session reuse but expire (#9824)

	* OpenSSL 3.2.1 30 Jan 2024 is also broken

	Import 4506461 from ruby_3_3 branch
	tentatively.
	---
	 test/net/http/test_https.rb | 2 +-
	 1 file changed, 1 insertion(+), 1 deletion(-)
hsbt pushed a commit to hsbt/ruby that referenced this pull request Apr 12, 2024
@nagachika @hsbt
merge revision(s) 64b6a01:
1512f76 
	Fix test session reuse but expire (ruby#9824)

	* OpenSSL 3.2.1 30 Jan 2024 is also broken

	Import 4506461 from ruby_3_3 branch
	tentatively.
	---
	 test/net/http/test_https.rb | 2 +-
	 1 file changed, 1 insertion(+), 1 deletion(-)
unak pushed a commit that referenced this pull request Apr 15, 2024
@nagachika @unak
merge revision(s) 64b6a01:
e917557 
	Fix test session reuse but expire (#9824)

	* OpenSSL 3.2.1 30 Jan 2024 is also broken

	Import 4506461 from ruby_3_3 branch
	tentatively.
	---
	 test/net/http/test_https.rb | 2 +-
	 1 file changed, 1 insertion(+), 1 deletion(-)
@hsbt hsbt added the Backport label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nurse @voxik @hsbt