Skip to content

Matches the return value of a JavaScript method with ? with a true/false decision in a JavaScript if statement #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2024
Merged

Matches the return value of a JavaScript method with ? with a true/false decision in a JavaScript if statement #443

merged 1 commit into from
May 4, 2024
+14 −4

Conversation

ledsun
Copy link
Contributor

@ledsun ledsun commented Apr 30, 2024

This pull request is based on the discussion in #434.

@ledsun
Matches the return value of a JavaScript method whose name ends in ? …
3c1bb02 
…with a true/false decision in a JavaScript if statement
@kateinoigakukun
Copy link
Member

Thanks! I'll merge this after the next patch release because this is a breaking change

@kateinoigakukun kateinoigakukun added this to the 2.6.0 milestone Apr 30, 2024
@kateinoigakukun kateinoigakukun merged commit 94ce022 into ruby:main May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ledsun @kateinoigakukun