Skip to content

Fix support for old rubies #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2021
Merged

Fix support for old rubies #14

merged 2 commits into from
Feb 10, 2021

Conversation

ivoanjo
Copy link
Contributor

@ivoanjo ivoanjo commented Feb 4, 2021

Hello there! 👋

While adding ruby2_keywords to @DataDog's ddtrace gem I discovered that it had a few incompatibilities with older rubies.

I went through every one of them, and replaced them with alternatives that work as far back as Ruby 2.0.
Out of curiosity, I tested 1.9 as well, and found there were further incompatibilities but I decided to stop at that point 🤣 .

Hopefully this is acceptable :)

@ivoanjo ivoanjo marked this pull request as draft February 4, 2021 12:12
@ivoanjo ivoanjo force-pushed the fix-support-for-old-rubies branch from 375ac45 to 63d1621 Compare February 4, 2021 12:14
@ivoanjo ivoanjo marked this pull request as ready for review February 4, 2021 12:27
@ivoanjo
Copy link
Contributor Author

ivoanjo commented Feb 4, 2021

Apologies for the extra noise! I hadn't spotted the existing GitHub CI setup when I first opened the PR so I updated it as well now.

Ready for review, and thanks a lot! :)

@nobu
Copy link
Member

nobu commented Feb 9, 2021

Cherry-picked some commits.
Could you rebase the rest?

And I’m not sure if docker-compose.yml is useful only on GitHub.
Do you intend to checked it out and use locally?

@ivoanjo
Explicitly declare support for Ruby >= 2.0.0
2c5e91c 
This can be used to clarify support, as well as in the future to drop
support for rubies, if so desired.
@ivoanjo
Add docker-compose.yml for easy testing of older rubies
acbb79a
@ivoanjo ivoanjo force-pushed the fix-support-for-old-rubies branch from 63d1621 to acbb79a Compare February 9, 2021 16:43
@ivoanjo
Copy link
Contributor Author

ivoanjo commented Feb 9, 2021

Thanks @nobu! I've rebased the two last commits.

And I’m not sure if docker-compose.yml is useful only on GitHub.
Do you intend to checked it out and use locally?

Yes, the docker-compose.yml is only for local testing. I added it as it was helpful for my own local testing (it's kinda hard to get these old rubies installed nowadays), but if you don't think it's useful, I can remove it.

Also, it would be great to have a 0.0.5 release with these fixes :) :) :)

@nobu nobu merged commit 97b4de7 into ruby:master Feb 10, 2021
@ivoanjo ivoanjo deleted the fix-support-for-old-rubies branch July 17, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivoanjo @nobu