Skip to content

Add a shim for Proc#ruby2_keywords #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2020
Merged

Add a shim for Proc#ruby2_keywords #3

merged 2 commits into from
Jan 8, 2020

Conversation

mame
Copy link
Member

@mame mame commented Jan 3, 2020

No description provided.

@pocke pocke mentioned this pull request Jan 3, 2020
Merged
pocke
pocke reviewed Jan 3, 2020
View reviewed changes
lib/ruby2_keywords.rb Outdated
@@ -13,3 +13,9 @@ def main.ruby2_keywords(*)
# nil
end
end

class Proc
def ruby2_keywords
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it needs respond_to? guard like other polyfills.

znz
znz reviewed Jan 6, 2020
View reviewed changes
lib/ruby2_keywords.rb
unless method_defined?(:ruby2_keywords)
def ruby2_keywords
self
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about alias ruby2_keywords itself?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't care either

@nobu nobu merged commit 07e126e into ruby:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znz znz znz left review comments

@pocke pocke pocke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mame @znz @pocke @nobu